Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Getting started: refactor 'Customizing Bootstrap' #10459

Merged
merged 5 commits into from
Sep 6, 2013
Merged

Docs - Getting started: refactor 'Customizing Bootstrap' #10459

merged 5 commits into from
Sep 6, 2013

Conversation

StevenBlack
Copy link
Contributor

There's still much to add to the "Customizing bootstrap" section. This is just a starter: normalizing what's already there for readability, keeping non-native speakers in-mind. In some places I added minor clarifications.

Notable changes here:

  • Shrank and normalized section whitespace breaks. It's three linefeeds everywhere now. Not sure if there's a standard for this, but this looks fine to my eye.
  • Most changes make shorter, less wordy sentences. There are exceptions where I felt clarity trumped brevity.

Looking forward, we should distinguish between 'Customizing Bootstrap'" (modify and extend as in this section), and "Customize and download" (theming and cherry-picking components and features with the wizard.)

<li>Rinse and repeat until you're happy with your customizations.</li>
</ul>
<p>Going beyond light customizations and into visual overhauls is just as straightforward as the above custom button. For a site like <a href="http://yourkarma.com">Karma</a>, which uses Bootstrap as a CSS reset with heavy modifications, more extensive work is involved, but well worth it in the end.</p>
<p>Once you are comfortable performing light customizations, visual overhauls are just as straightforward. For a site like <a href="http://yourkarma.com">Karma</a>, which uses Bootstrap as a CSS reset with heavy modifications, more extensive work is involved. But the same principle applies: invoke Bootstrap's default stylesheet first, then invoke your custom stylesheets.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"include" would make more sense than "invoke", IMO. CSS isn't a programming language per se.

@@ -24,7 +24,7 @@ <h3 id="download-additional">Additional downloads</h3>
<h4>
<a href="{{ site.download_source }}" onclick="_gaq.push(['_trackEvent', 'Getting started', 'Download', 'Download source']);">Download source code</a>
</h4>
<p>Get the latest Bootstrap LESS and JavaScript source code by downloading it directly from GitHub.</p>
<p>Get the latest Bootstrap .LESS and JavaScript source code by downloading it directly from GitHub.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and L53 shouldn't include a .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -51,7 +51,7 @@ <h3 id="download-cdn">Bootstrap CDN</h3>

<div class="bs-callout bs-callout-warning" id="callout-less-compilation">
<h4>Compiling Bootstrap's LESS files</h4>
<p>If you work with Bootstrap's uncompiled source code, you need to compile the LESS files to produce usable CSS files. For LESS compilation, we only officially support <a href="http://twitter.github.io/recess/">Recess</a>, which is Twitter's CSS hinter based on <a href="http://lesscss.org">less.js</a>.</p>
<p>If you work with Bootstrap's uncompiled source code, you need to compile the .LESS files to produce usable CSS files. For compiling LESS files into CSS, we only officially support <a href="http://twitter.github.io/recess/">Recess</a>, which is Twitter's CSS hinter based on <a href="http://lesscss.org">less.js</a>.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the dot here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (sorry I missed that. Found another actually.)

@Merg1255
Copy link

Merg1255 commented Sep 6, 2013

Providing a screenshot of the final product would be nice.

@StevenBlack
Copy link
Contributor Author

Here you go, well, 90% of it. My capture tool doesn't scroll from an arbitrary point.

@woshicixide
Copy link

good

@Merg1255
Copy link

Merg1255 commented Sep 6, 2013

It looks nice.

@StevenBlack
Copy link
Contributor Author

  • Ping *

I'd like to further develop this section, building upon its latest state, in a new branch.

In other words, basic cleanup (this PR) first, then its extension with more advanced workflows, which are surely a separate discussion from this first-pass cleanup.

@mdo mdo mentioned this pull request Sep 6, 2013
@mdo mdo merged commit 0067399 into twbs:master Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants