Fixes 10212 - Make custom max-width on row conform to Bootstrap convention #10227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap break point for tablet portrait 768 keeps the row intact, so it's not appropriate to have off-canvas elements at that width. Custom off-canvas.css should be breakpoint 767px
| @@ -14,7 +14,7 @@ footer { | |||
| * Off Canvas | |||
| * -------------------------------------------------- | |||
| */ | |||
| @media screen and (max-width: 768px) { | |||
| @media screen and (max-width: 767px) { | |||
There was a problem hiding this comment.
this should conform to max-width convention of Bootstrap. row-fluid does not break at 768, it breaks at 767
html overflow-x must be hidden to prevent accidental x-scroll on small screens. This is more apparent with touch screens, where the user often gestures diagonally instead of a true vertical gesture.
| @@ -2,6 +2,9 @@ | |||
| * Style tweaks | |||
| * -------------------------------------------------- | |||
| */ | |||
| html { | |||
| overflow-x: hidden; | |||
There was a problem hiding this comment.
necessary to prevent unintentional x-scroll on small viewports
mdo
added a commit
that referenced
this pull request
Sep 4, 2013
Fixes 10212 - Make custom max-width on row conform to Bootstrap convention
mdo
added a commit
that referenced
this pull request
Sep 4, 2013
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap break point for tablet portrait 768 keeps the row intact, so it's not appropriate to have off-canvas elements at that width. Custom off-canvas.css should be breakpoint 767px
#10212