javascript.html: add data-ride note #10146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just what I was looking for :) |
| @@ -1755,7 +1755,7 @@ <h2 id="carousel-examples">Examples</h2> | |||
| <h2 id="carousel-usage">Usage</h2> | |||
|
|
|||
| <h3>Via data attributes</h3> | |||
| <p>Use data attributes to easily control the position of the carousel. <code>data-slide</code> accepts the keywords <code>prev</code> or <code>next</code>, which alters the slide position relative to its current position. Alternatively, use <code>data-slide-to</code> to pass a raw slide index to the carousel <code>data-slide-to="2"</code>, which shifts the slide position to a particular index beginning with <code>0</code>.</p> | |||
| <p>Use data attributes to easily control the position of the carousel. <code>data-slide</code> accepts the keywords <code>prev</code> or <code>next</code>, which alters the slide position relative to its current position. Alternatively, use <code>data-slide-to</code> to pass a raw slide index to the carousel <code>data-slide-to="2"</code>, which shifts the slide position to a particular index beginning with <code>0</code>. The <code>data-ride="carousel"</code> attribute is used to mark a carousel as animating starting at page load.</p> | |||
There was a problem hiding this comment.
The new sentence should probably go in a new paragraph since it doesn't concern positioning.
carousel docs were missing mention of the data-ride attribute used to automatically start the carousel at load time
|
Good feedback, @cvrebert. Just updated my PR. |
cvrebert
added a commit
that referenced
this pull request
Aug 26, 2013
javascript.html: add data-ride note
|
Great! Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carousel docs were missing mention of the data-ride attribute
used to automatically start the carousel at load time