Fixes #10116: Deprecate container-{device} vars #10125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es customizer and grid to do the same
|
I think you're gonna need to swap the defaulting in |
|
The Travis failure is unrelated and transient, so it's safe to ignore. |
|
Looks good otherwise. |
|
You may add a deprecation alert as in the other variables ;) |
Closed
|
@mdo Erm, the backward compatibility issue was never fixed... |
|
Oh, didn't see 50bf4d4; nevermind! |
cvrebert
referenced
this pull request
Sep 1, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10116.
Swaps
@container-{device}classes for@container-{size}classes. Also updates the customizer and grid to use the new variables (and fixes a missing@screen-*-minchange)./cc @cvrebert