Add role="button" to <a> buttons #10112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's gonna get "squared away". |
|
Accessibility > CSS > JavaScript. With now 1%+ of the web using Bootstrap, this argument is only going to get louder and more frequent. Better to deal with it now than later. |
added 2 commits
August 24, 2013 16:29
These should really be <button> elements, but until that gets squared away, this will suffice.
Missed the <a class="btw" in my regex search
|
OK, updated, but not seeing it reflected in this PR. I see your edits in my branch though. I think it's good to go? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should really be
<button>elements, but until that gets squared away, this will suffice.