-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the Copy buttons in docs when Flash is not available #16269
Comments
Sounds perfectly reasonable. |
LGTM. maybe a nice addition would be to explore the possibility of using the clipboard API http://www.w3.org/TR/clipboard-apis/ where supported, and ditch the flash thing altogether? |
@patrickhlauke, @JamesMGreene had some thoughts on it in zeroclipboard/zeroclipboard#171. From what I've read it doesn't sound like it's super feasible right now for a lot of browsers (http://caniuse.com/#feat=clipboard). |
Sadly correct: the HTML Clipboard API is still basically unimplemented in all browsers, minus a few that support only its "paste" event. Believe me... when it's available in ANY browser, ZeroClipboard will be utilizing it as the first-class approach ASAP and demoting our Flash bits to second-class (fallback). |
@tarebyte Anyway, we'd welcome a pull request. |
You guys may be interested in my comment on zeroclipboard/zeroclipboard#552. Feedback is always welcomed. |
@cvrebert this may seem like a silly question, but how are you minifying your JS for the docs? |
@cvrebert awesome thanks! I was look at the |
Hi There,
I'm opening up an issue before making a pull request to see if this was something that people might want.
I would like to hide the the copy button for the code snippets when the browser doesn't support flash.
Here is a before and after:
I don't think it takes away from the design at all, and it would be really useful for people like me who use Firefox and don't have flash installed.
Thanks!
The text was updated successfully, but these errors were encountered: