Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers' font is hardcoded? #11741

Closed
XhmikosR opened this issue Dec 6, 2013 · 5 comments
Closed

Headers' font is hardcoded? #11741

XhmikosR opened this issue Dec 6, 2013 · 5 comments
Labels
Milestone

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Dec 6, 2013

h1,
h2,
h3,
h4,
h5,
h6,
.h1,
.h2,
.h3,
.h4,
.h5,
.h6 {
  font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
  font-weight: 500;
  line-height: 1.1;
  color: inherit;
}

When overwriting the default font in body, I'd expect this to be inherited for the headers too. Is there any reason for this or it's a mistake?

BTW, since normalize.css sets the default font in html shouldn't Bootstrap set it there too? In this case you could remove "sans-serif" from your font property.

EDIT: I guess this is done on purpose after looking at type.less... Perhaps it should be set to inherit as a default then?

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 6, 2013

inherit would seem to be backwards-incompatible.

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 6, 2013

Can you elaborate on that?

I just noticed it by accident and I've been using Bootstrap for a long time. I can see why some people would like to have this configurable but the default should inherit the base font to make things easier...

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 6, 2013

@XhmikosR Folks may be relying on that fact that it doesn't inherit, so changing it could break folks' sites (in that the heading font might change unexpectedly). IMO, that makes such a change backwards-incompatible, and we can only make such changes in major releases (e.g. v4).

@mdo
Copy link
Member

mdo commented Dec 6, 2013

Ugh, this is a problem of CSS practicality vs LESS functionality. Some folks want the ease of use you're talking bout @XhmikosR, and others want variables for fucking everything. The variable is why this is happening I think. Setting it to inherit might cause some problems, too. Can't recall all the changes right now.

@mdo mdo closed this as completed in 1f9bfa8 Dec 8, 2013
@mdo mdo mentioned this issue Dec 8, 2013
@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 8, 2013

Thanks!

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants