Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap-theme.css: Button corners look funny in IE9 due to gradient filter #10620

Closed
arechsteiner opened this issue Sep 13, 2013 · 5 comments
Closed
Labels
Milestone

Comments

@arechsteiner
Copy link
Contributor

Code snippet:

<link href="css/bootstrap.css" rel="stylesheet" media="screen">
<link href="css/bootstrap-theme.css" rel="stylesheet" media="screen">
...
<button type="submit" class="btn btn-success">Submit</button>

Result in IE9 (magnified):

2013-09-13 17_57_10-bootstrap 101 template

I'm not entirely sure what causes this bug. But I think it has something to do with the IE gradient filter called by the mixin .btn-styles(@btn-color: #555;) in theme.less, which then calls the vertical gradient mixin, with this attribute:

filter: e(%("progid:DXImageTransform.Microsoft.gradient(startColorstr='%d', endColorstr='%d', GradientType=0)",argb(@start-color),argb(@end-color))); // IE9 and down

When I comment this filter, then the button has rounded corners (but lacks gradient obviously). But then again, I think the same filter was used in Bootstrap 2.3 and there it works fine.

@saas786
Copy link
Contributor

saas786 commented Sep 15, 2013

@arechsteiner it's not a core framework issue, its a theme related issue. So it is v. highly unlikely you get theme fixes support. Anyway, your solution lies in this post
http://stackoverflow.com/questions/4036963/in-ie-how-do-i-remove-a-filter

use ie9 conditional comment and load ie9 specific css and in that set filter: none; so ie9 won't screw it.

And it should solve your issue.

@arechsteiner
Copy link
Contributor Author

@saas786:

it's not a core framework issue, its a theme related issue.

Not sure what you mean, bootstrap-theme.css is part of the Bootstrap framework and delivered with it. It's not a third party component.

use ie9 conditional comment and load ie9 specific css and in that set filter: none

I don't think that's a good solution as it would simply remove the gradient in IE9. As I said earlier, the whole thing worked fine in BS 2.3.2.

@cvrebert
Copy link
Collaborator

@saas786 No, the theme is absolutely officially supported, and we're definitely going to address this.

@mdo
Copy link
Member

mdo commented Sep 17, 2013

In 2.x we removed the gradient for IE9. Edit: And we'll do the same thing here.

@arechsteiner
Copy link
Contributor Author

@mdo: Had to check again to realize this. I was under the impression that there was a gradient in IE9. Well then..

@mdo mdo closed this as completed in d8fab5a Oct 21, 2013
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
…less due to bleed through with rounded corners
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
…less due to bleed through with rounded corners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants