Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs missing notice that tooltip/popover data-api is opt-in only #10324

Closed
cvrebert opened this issue Aug 31, 2013 · 2 comments · Fixed by #10338
Closed

Docs missing notice that tooltip/popover data-api is opt-in only #10324

cvrebert opened this issue Aug 31, 2013 · 2 comments · Fixed by #10338
Labels
confirmed docs js
Milestone
v3.0.1

Comments

@cvrebert
Copy link
Collaborator

The v2.3.2 docs had the following notice, which is missing from the new docs yet is still applicable AFAICT:

For performance reasons, the tooltip and popover data-apis are opt in, meaning you must initialize them yourself.
@cvrebert cvrebert mentioned this issue Aug 31, 2013
Closed
@juthilo
Copy link
Collaborator

juthilo commented Aug 31, 2013

Yup, the popover section still has that note, however the tooltip's one was accidentally removed when v2.3.0 was merged into 3.0.0-wip. Should it be a note or a callout?

@cvrebert
Copy link
Collaborator Author

I vote for callout.

juthilo added a commit that referenced this issue Aug 31, 2013
@juthilo
Fix #10324: Add opt-in note to tooltip docs
95c796d 
* Re-added a note (now callout) about need to opt in to tooltip docs
* Converted same note in popover section to callout
@juthilo juthilo mentioned this issue Aug 31, 2013
Merged
mdo added a commit that referenced this issue Sep 11, 2013
@mdo
Merge pull request #10338 from twbs/readd-optin-notes
6ea2893 
Fix #10324: Add opt-in note to tooltip docs
@mdo mdo mentioned this issue Sep 11, 2013
Closed
@cvrebert cvrebert mentioned this issue Sep 15, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs js
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging a pull request may close this issue.

Fix #10324: Add opt-in note to tooltip docs twbs/bootstrap
2 participants
@cvrebert @juthilo