Skip to content

Commit

Permalink
Reset select:disabled opacity and null-ify color to fix rendering dif…
Browse files Browse the repository at this point in the history
…ferences in Chrome
  • Loading branch information
mdo committed Mar 2, 2021
1 parent 205e2ca commit 6d93a13
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
12 changes: 7 additions & 5 deletions scss/_reboot.scss
Original file line number Diff line number Diff line change
Expand Up @@ -420,24 +420,26 @@ textarea {
}

// Remove the inheritance of text transform in Firefox

button,
select {
text-transform: none;
}

// Set the cursor for non-`<button>` buttons
//
// Details at https://github.com/twbs/bootstrap/pull/30562
[role="button"] {
cursor: pointer;
}

// Remove the inheritance of word-wrap in Safari.
// See https://github.com/twbs/bootstrap/issues/24990

select {
// Remove the inheritance of word-wrap in Safari.
// See https://github.com/twbs/bootstrap/issues/24990
word-wrap: normal;

// Undo the opacity change from Chrome
&:disabled {
opacity: 1;
}
}

// Remove the dropdown arrow in Chrome from inputs built with datalists.
Expand Down
2 changes: 1 addition & 1 deletion scss/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -796,8 +796,8 @@ $form-select-indicator-padding: $form-select-padding-x * 3 !default; // Extr
$form-select-font-weight: $input-font-weight !default;
$form-select-line-height: $input-line-height !default;
$form-select-color: $input-color !default;
$form-select-disabled-color: $gray-600 !default;
$form-select-bg: $input-bg !default;
$form-select-disabled-color: null !default;
$form-select-disabled-bg: $gray-200 !default;
$form-select-disabled-border-color: $input-disabled-border-color !default;
$form-select-bg-position: right $form-select-padding-x center !default;
Expand Down

0 comments on commit 6d93a13

Please sign in to comment.