libexpr/primops: crank up our user agent#10
Merged
tazjin merged 1 commit intotvlfyi:2.3-maintenancefrom Sep 2, 2025
Merged
Conversation
Author
|
|
Author
Actually not a problem, even with Nix 2.3.18: 0c5333a. |
sternenseemann
force-pushed
the
user-agent
branch
from
c2e1544 to
d312938
Compare
tazjin
reviewed
Sep 1, 2025
src/libexpr/primops.cc
Outdated
| /* Set our user agent string, so we can evaluate Nixpkgs. | ||
| See also <https://git.lix.systems/lix-project/lix/src/commit/4a119e6e46f/lix/libexpr/builtin-constants/nixVersion.md>. | ||
| */ | ||
| mkString(v, "2.18.3-tvl"); |
Member
There was a problem hiding this comment.
maybe we should go full browser? "2.18.3-tvl-cppnix-2.3-actual` )))
Author
There was a problem hiding this comment.
Sounds good, applied. I initially copied Lix's approach who intentionally picked a static string that makes sense with existing checks, but they would never change as a way of disagreeing with this builtin existing. However, there is no reason we can't be a bit more whimsical about it.
See NixOS/nixpkgs@fa0cba1. We'll see how dependent nixpkgs will grow on newer and features and how feasible it is to continue using Nix 2.3. The compat code that will be immediately removed looks like it doesn't actually affect Nix 2.3.18 which already had some fixes backported: - NixOS/nixpkgs#433101. Some features of fileset won't work anymore, but fileset is disallowed in nixpkgs anyways. The documentation workaround only affects Nix < 2.3.5. - NixOS/nixpkgs#433055. The fix for NIX_ATTRS_* has been backported to Nix 2.3.18.
sternenseemann
force-pushed
the
user-agent
branch
from
d312938 to
1d0dbda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Edited.)
See NixOS/nixpkgs@fa0cba1.
We'll see how dependent nixpkgs will grow on newer and features and how
feasible it is to continue using Nix 2.3.
The compat code that will be immediately removed looks like it doesn't
actually affect Nix 2.3.18 which already had some fixes backported:
won't work anymore, but fileset is disallowed in nixpkgs anyways.
The documentation workaround only affects Nix < 2.3.5.
has been backported to Nix 2.3.18.