Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cmake as a build dependency #16

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Adds cmake as a build dependency #16

merged 1 commit into from
Feb 20, 2024

Conversation

fakufaku
Copy link
Collaborator

@fakufaku fakufaku commented Feb 17, 2024

The PR adds cmake as a build dependency.

Problem

On some systems (e.g., google colab), the cmake python package is pre-installed.
In this case, the cmake command calls a script that calls this package instead of the original cmake executable.

However, the python build system will create an empty build environment where the cmake python package is not available, leading to an import error.

See issue #15

Solution

Adding cmake as a build dependency solves the problem by installing the cmake python package as part of the build environment.

@fakufaku fakufaku marked this pull request as draft February 17, 2024 07:48
@fakufaku fakufaku requested a review from tuxu February 17, 2024 07:49
@fakufaku fakufaku self-assigned this Feb 17, 2024
@fakufaku fakufaku added the bug label Feb 17, 2024
Copy link
Owner

@tuxu tuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@fakufaku fakufaku marked this pull request as ready for review February 20, 2024 01:00
@fakufaku fakufaku merged commit d737def into master Feb 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants