Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #39

Closed
wants to merge 1 commit into from
Closed

Fix typo #39

wants to merge 1 commit into from

Conversation

hugok79
Copy link
Contributor

@hugok79 hugok79 commented Aug 10, 2024

fix typo pt-PT

@hugok79 hugok79 closed this Aug 10, 2024
@hugok79 hugok79 deleted the patch-3 branch August 10, 2024 22:47
@hugok79
Copy link
Contributor Author

hugok79 commented Aug 19, 2024

@perepujal typo in values-pt-rPT

It shouldn't be values-pt-PT ?

@perepujal
Copy link
Member

Hi Hugo, the only thing I can say is that with values-pt-rPT the translations work, and that with values-pt-PT they do not work.
I don't know why, if there is some Android reason for adding the 'r' or what, but in the tests I did the 'r' is needed

Best
Pere

@hugok79
Copy link
Contributor Author

hugok79 commented Aug 19, 2024

Hi.,
I have no idea.... I just translate, I don't code. But I see that the Tradicional Chinese zh_TW language also have an "r" before TW.
I don't know if it has to do with the fact that the lang code is pt_PT instead of pt or the Brazilian Portuguese pt_BR

@hugok79
Copy link
Contributor Author

hugok79 commented Aug 19, 2024

Perhaps Bill Kendrick from Tux Paint can help?

@perepujal
Copy link
Member

I found something that seems authoritative, from Android developers:
https://developer.android.com/guide/topics/resources/providing-resources#AlternativeResources
scroll a little down to the "Language, script (optional), and region (optional)" section:

"The language is defined by a two-letter ISO 639-1 language code, optionally followed by a two-letter ISO 3166-1-alpha-2 region code (preceded by lowercase r)"

@hugok79
Copy link
Contributor Author

hugok79 commented Aug 19, 2024

Interesting. So it always has to do with the language/region code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants