-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mastodon Redirect support #4194
base: develop
Are you sure you want to change the base?
Conversation
@@ -55,6 +55,7 @@ | |||
<activity | |||
android:name=".MainActivity" | |||
android:configChanges="orientation|screenSize|keyboardHidden|screenLayout|smallestScreenSize" | |||
android:launchMode="singleTask" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to add this so Tusky could receive links while it's still running in the background. I don't think it breaks anything, but let me know.
|
||
// Makes sure the Intent opens in the browser instead of something like Mastodon Redirect. | ||
intent.selector = Intent(Intent.ACTION_VIEW, Uri.parse("https://")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A blank-URL selector guarantees the link won't accidentally open in an app that supports the domain (e.g., Mastodon Redirect, which could cause a launch loop).
I fail to test that.
similar result on a real device and with Firefox |
Try using the "Open Link" share target instead. Mastodon Redirect has so many domains that it can break whatever API Chrome is using to read where to open links. I've been waiting on an update to instances.social's API for better active-status filtering. |
Same result with "open link" :( |
Try revoking any links you enabled for auto-handling. You might also need to try opening a link from something like Keep or Telegram. I want to reduce the number of handled domains in Mastodon Redirect, but I haven't been able to find a better source yet. |
I've reduced the number of supported domains by about 1000 in Mastodon Redirect. It's still over 11k total, but it should be less prone to crashing. |
f1941db
to
e8a28bc
Compare
I also added a new share target for opening links, which uses the same path Mastodon Redirect does. |
e8a28bc
to
183fb7e
Compare
Any news here? 🙈 |
@zacharee This PR needs to be rebased or have a merge commit from tuskyapp:develop. If you can not afford time for solving this, I can gladly take over. (no tusky maintainer, just want to help getting this done :) ) |
183fb7e
to
b076361
Compare
b076361
to
dcb87a4
Compare
@Lazalatin can you bring that forward? |
Mastodon Redirect is my app that handles redirecting Mastodon links to supported apps, so the apps don't have to maintain their own list of supported instances.
This PR adds auto-detect support for Mastodon Redirect, so Tusky can be chosen for opening Mastodon links.
Addresses #3865
To test: