Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify upload pausing #42

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Modify upload pausing #42

merged 5 commits into from
Aug 10, 2021

Conversation

cdr-chakotay
Copy link
Collaborator

@cdr-chakotay cdr-chakotay commented Jul 14, 2021

This PR overloads the TusUploader#finish() method in order to provide a pausable upload, which doesn't close the underlying InputStream.

Make uploads pausable without closing file input Streams
Add a pause functionality, which doesn't close the InputStream
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We might have hit a road block here, which could complicate matter a bit :|

src/main/java/io/tus/java/client/TusUploader.java Outdated Show resolved Hide resolved
src/main/java/io/tus/java/client/TusUploader.java Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@cdr-chakotay cdr-chakotay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrated those changes in a slightly different manner.

Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few formatting fixes on my own and looks ready now! Thanks!

@Acconut Acconut merged commit 9213a1f into tus:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants