fix: update rclcpp action api#19
Merged
roni-kreinin merged 1 commit intoturtlebot:galacticfrom Aug 9, 2022
Merged
Conversation
928b38e to
e8cfed7
Compare
Author
|
@roni-kreinin Could you create |
Contributor
|
|
Author
|
The old api is compatible, but is marked as deprecated even in |
e8cfed7 to
8a9d407
Compare
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
8a9d407 to
bafa128
Compare
Contributor
|
Merging for galactic and will keep this API for humble. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daisuke Nishimatsu border_goldenmarket@yahoo.co.jp
Description
update rclcpp action api for humble/rolling
This api change was introduced by ros2/rclcpp#1311
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce. Also list any relevant details for your test configuration.
# Run this command ros2 launch package launch.pyChecklist