vector-search: fix attach #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
approved these changes
Oct 29, 2024
sivukhin
added a commit
that referenced
this pull request
Oct 30, 2024
- new release will include fix for vector search in attached DBs (see #1799)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eponymous virtual tables exists only in main schema and any prefix before them is no-op for SQLite (like
attached.vector_top_k(...); see https://www.sqlite.org/vtab.html#epovtab)So, in order to use vector search from other schema name - we need to develop internal convention that index name string argument can have schema name prefix (in similar way as usual SQL query):
SELECT * FROM vector_top_k('attached.t_idx', vector('[1,2,3]'), 4).This PR support this feature which will allow users to query vector search indices from attached DBs.