Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable rename1 bjs #996

Open
wants to merge 258 commits into
base: master
Choose a base branch
from
Open

Variable rename1 bjs #996

wants to merge 258 commits into from

Conversation

bensjsilverstein
Copy link

Updated variable naming

bensjsilverstein and others added 30 commits June 1, 2022 14:32
@bensjsilverstein
Feat - Add id and name test
29adaf8
@bensjsilverstein
Feat - Add id and name methods
071c6a1
@bensjsilverstein
Feat - Add 'exists' test
6a18dd7
@bensjsilverstein
Feat - Add MerchantRepository class
3add087
@bensjsilverstein
Feat - Add test for 'all' method
e7b7710
@bensjsilverstein
Feat - Add 'all' method
78f3104
@bensjsilverstein
Fix -
b4e493e 
Adjust 'all' test to include count.
Adjust initialize to include more CSV path
@bensjsilverstein
Feat - Add 'find_by_id' test
05198a5
@bensjsilverstein
Fix -
cc806c1 
Adjust 'find_by_id' method
Adjust 'find_by_id' test
@bensjsilverstein
Feat - Add 'find_by_name' test
8bd70d5
@bensjsilverstein
Feat - Add 'find_by_name' method
92684cc
@bensjsilverstein
Feat - Add 'find_all_by_name' test
2a8c97f
@bensjsilverstein
Feat - Add 'find_all_by_name' method
b9677a6
@bensjsilverstein
Feat - Add 'create' test
6250075
@bensjsilverstein
Fix - remove 'create' from expect statements
4850cad
@bensjsilverstein
Fix - adjust 'create' test spacing
82ee722
@bensjsilverstein
Feat - Add MerchantRepository 'update' test
ebf0b70
@bensjsilverstein
Feat - Add MerchantRepository 'update' method
d0df47c
@bensjsilverstein
Fix - Adjust expect statement (remove .all)
848f221
@Ethan-t-n
Merge pull request #2 from Ethan-t-n/merchant_test_bjs
f88d7b7 
Merchant test bjs
@Ethan-t-n
Merge branch 'master' of github.com:Ethan-t-n/black_thursday
ebb0cb4
@bensjsilverstein
Feat - Add MerchantRepository 'delete' test
79a0df2
@bensjsilverstein
Feat - Add MerchantRepositroy 'delete' method
47c9135
@sdecesari
Merge pull request #3 from Ethan-t-n/add_merchantrepo_methods_and_tes…
19fcdef 
…ts_bjs

Add merchantrepo methods and tests bjs
@Ethan-t-n
Merge branch 'master' of github.com:Ethan-t-n/black_thursday
4e16cba
@Ethan-t-n
add test for item
ce83b14
@Ethan-t-n
add class for items
34a1d73
@Ethan-t-n
add unit_price_to_dollars
cad6c3d
@Ethan-t-n
add_price_to_dollar
9830779
@Ethan-t-n
add item repository initial test
3ac8f34
sdecesari and others added 30 commits June 6, 2022 12:52
@sdecesari
Test -Refactor time to be consistant in both item and item_repository…
f0b810a 
… spec
@sdecesari
Test -Clean up lines in spec
cd50e3b
@sdecesari
Test -Clean up lines in spec
9fd3ca1
@sdecesari
Feat -Remove extra lines
4cca574
@sdecesari
Feat -Remove extra lines
146bc58
@sdecesari
Feat -Remove extra lines
f3aab54
@sdecesari
Feat -Remove extra lines
8b24097
@Ethan-t-n
add delete test for invoice repo
16432fa
@Ethan-t-n
add delete method
9bea140
@sdecesari
Feat -Add missing end
c1b0d11
@brycesimonds
Merge pull request #14 from Ethan-t-n/feat/add_delete_method
0d8c6c4 
Feat/add delete method
@sdecesari
Remove extra line
b03d070
@sdecesari
Remove pry and fix syntax
d538b12
@sdecesari
Remove extra line fix syntax and update time
7a2e2b2
@sdecesari
Remove extra lines fix syntax
73487f5
@sdecesari
Remove extra lines
fd411c9
@sdecesari
Remove extra lines
5aca32f
@sdecesari
Remove extra line and fix syntax
3407d71
@sdecesari
Remove extra line
0019575
@sdecesari
Fix syntax and add require_relative entry
4987069
@Ethan-t-n
Merge pull request #15 from Ethan-t-n/refactor_iteration0-sd
f6d890a 
Refactor iteration0 sd
@bensjsilverstein
Fix - Missing 'end' on invoice_total method
5f1af54
@bensjsilverstein
Test - Fix 'average_item_price_for_merchant'
e25e3f0 
Test - Add 'average_average_price_per_merchant'
Test - Add 'can calculate standard_deviation of item_price'
@bensjsilverstein
Feat - Add 'price_std_dev' method
826f9d4 
Fix - Adjust 'golden_items' method
Fix - Adjust rounding on various methods
@sdecesari
Merge pull request #16 from Ethan-t-n/iteration1_refactor_bjs
16ac974 
Iteration1 refactor bjs
@Ethan-t-n
refactoring sales_analyst
ee6db95
@brycesimonds
Merge branch 'master' into feat/refactor_iteration0-sd
296d8c6
@brycesimonds
Merge pull request #17 from Ethan-t-n/feat/refactor_iteration0-sd
dffde2a 
Feat/refactor iteration0 sd
@bensjsilverstein
Fix - change vairable name
bdc147d
@bensjsilverstein
Fix - change variable name
696bf19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bensjsilverstein @Ethan-t-n @sdecesari @brycesimonds