Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if-condition for posting negative message on PRs is wrong #14

Closed
turing85 opened this issue Feb 28, 2023 · 0 comments · Fixed by #17
Closed

if-condition for posting negative message on PRs is wrong #14

turing85 opened this issue Feb 28, 2023 · 0 comments · Fixed by #17
Assignees
@turing85
Labels
bug Something isn't working

Comments

@turing85
Copy link
Owner

The if-condition for step Update PR status comment on failure is incorrect. It should include a (failure() steps.generate-report.conclusion != 'success') (probably as first check) and remove the steps.generate-report.conclusion != 'success' at the end.
@turing85 turing85 added the bug Something isn't working label Feb 28, 2023
@turing85 turing85 self-assigned this Feb 28, 2023
turing85 added a commit that referenced this issue Feb 28, 2023
@turing85
Bug fixes
4217f2f 
- Temporary fix for #13 until phoenix-actions/test-reporting#31 is merged
- Fixed if-condition of "Update PR status comment on failure" (#14)
- Fixed variable name in Cancel Workflow (#15)
- Fixed default for comment-message-failure (#16)
@turing85 turing85 mentioned this issue Feb 28, 2023
Merged
turing85 added a commit that referenced this issue Feb 28, 2023
@turing85
Bug fixes
3692684 
- Temporary fix for #13 until phoenix-actions/test-reporting#31 is merged
- Fixed if-condition of "Update PR status comment on failure" (#14)
- Fixed variable name in Cancel Workflow (#15)
- Fixed default for comment-message-failure (#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turing85 turing85

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug fixes turing85/publish-report
1 participant
@turing85