Re-add AWS CloudWatch source #131
Conversation
ParthaI
force-pushed
the
re-add-cloudwatch-source
branch
from
d514484 to
39a8b11
Compare
| // It ensures that the required LogGroupName field is provided and not empty. | ||
| func (c *AwsCloudWatchSourceConfig) Validate() error { | ||
| if c.LogGroupName == "" { | ||
| return fmt.Errorf("log group is required and cannot be empty") |
There was a problem hiding this comment.
Should this be the hcl field name log_group_name
There was a problem hiding this comment.
Yes, it would be more appropriate to use the HCL field name. Updated the statement
| // AWS CloudWatch Logs client | ||
| client *cloudwatchlogs.Client | ||
| // List of errors encountered during collection | ||
| errorList []error |
There was a problem hiding this comment.
We don't seem to be using this, we instantiate it in Init func but never append to it?
There was a problem hiding this comment.
Used the errorList property to collect all the errors during the collection.
| // getClient initializes and returns an AWS CloudWatch Logs client | ||
| // It uses the provided region or falls back to the default region | ||
| func (s *AwsCloudWatchSource) getClient(ctx context.Context) (*cloudwatchlogs.Client, error) { | ||
| tempRegion := defaultCloudwatchRegion |
There was a problem hiding this comment.
tempRegion? I'd just call it region
There was a problem hiding this comment.
Updated to use region instead
| isFirst := true | ||
|
|
||
| for _, state := range s.LogStreams { | ||
| if isFirst { | ||
| earliestTime = state.GetStartTime() | ||
| isFirst = false |
There was a problem hiding this comment.
Instead of using a bool, you can check the index of the iteration?
| isFirst := true | ||
|
|
||
| for _, state := range s.LogStreams { | ||
| if isFirst { | ||
| latestTime = state.GetEndTime() | ||
| isFirst = false |
There was a problem hiding this comment.
Instead of bool, could use index of iteration?
|
|
||
| // GetFromTimeForStream returns the start time for a specific log stream. | ||
| // If the stream doesn't exist in the state, returns zero time. | ||
| func (s *CloudWatchCollectionState) GetFromTimeForStream(logStreamName string) time.Time { |
There was a problem hiding this comment.
You're pulling StartTime, GetStartTimeForStream
|
|
||
| // GetToTimeForStream returns the end time for a specific log stream. | ||
| // If the stream doesn't exist in the state, returns zero time. | ||
| func (s *CloudWatchCollectionState) GetToTimeForStream(logStreamName string) time.Time { |
There was a problem hiding this comment.
You're pulling EndTime, GetEndTimeForStream
Example query results
Results