Add Application Signals Service Level Objective Table

[johnlayton]

Integration test logs

Logs

Add passing integration test logs here

Example query results

Results

Add example SQL query results here (please include the input queries as well)

[johnlayton]

Query, how do I identify regions supported by this application_signals service?

[ParthaI]

Hello @johnlayton,

Thank you for your contribution! 🎉

In this plugin, we are currently using AWS Go SDK v1, specifically version v1.51.19. Unfortunately, in this version, the AWS Application Signals service is not yet available. After reviewing the AWS Go SDK v1 repository, I found that support for this service was added in version v1.53.20.

To use the EndpointID of the Application Signals service, we would need to update the AWS Go SDK v1 to v1.53.20. This would enable us to leverage the EndpointID reference.

Alternatively, if we prefer not to update the AWS SDK v1, we could potentially use a hardcoded value (application-signals) to retrieve the supported regions for the Application Signals service. However, I’m not entirely certain if using a hardcoded value would fully resolve the issue in listing supported regions for the service.

Please let us know what works best for you.

Thanks again!

[johnlayton]

Great feedback. Just to confirm (I am new to Go) the go.mod and go.sum changes need to be reverted except for adding github.com/aws/aws-sdk-go-v2/service/applicationsignals v1.3.1?

[ParthaI]

Hello @johnlayton,

I noticed that the current package version we are using in the AWS plugin (v1.27.0) already supports the applicationsignals service. Therefore, there’s no need to update AWS SDK V2 to support this table.

However, for the service endpoint reference, we may need to update AWS SDK V1 to version v1.53.20.

To resolve this, you can follow the steps outlined below:

1. Revert the AWS SDK V2 to v1.27.0 by running the command: go get github.com/aws/aws-sdk-go-v2@v1.27.0.
2. Update AWS SDK V1 to v1.53.20 to obtain the endpoint ID reference by running the command: go get github.com/aws/aws-sdk-go@v1.53.20.
3. Replace the hardcoded endpoint ID value here.
4. Make any necessary adjustments to the aws_application_signals_service_level_objective table, depending on the API behavior, if required.

Please let me know if you need any further clarification.

Thanks!

[johnlayton]

Hi. I updated the dependencies as suggested. I still see changes to configsources and endpoints, and the linting fails. Is this expected or am I still missing something?

Is it related to this comment -> #2291 (review)

[ParthaI]

Hello @johnlayton, thank you so much for your efforts and contribution! I’ve merged the PR into a branch.

The lint failure was caused by the use of the deprecated function EndpointResolverWithOptionsFunc with AWS SDK V2 version 1.30.5.

I'll look into resolving it.

[ParthaI]

Hello @johnlayton,

I’ve left a few initial review comments—whenever you have a moment, please take a look.

Additionally, we are in the process of updating the AWS SDK V2 to version v1.30.4. Could you kindly ensure that this update does not introduce any breaking changes to the existing tables?

Thank you!