Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table aws_backup_vault.closes#160 #163

Merged
merged 18 commits into from
Apr 6, 2021
Merged

Add table aws_backup_vault.closes#160 #163

merged 18 commits into from
Apr 6, 2021

Conversation

bigdatasourav
Copy link
Contributor

@bigdatasourav bigdatasourav commented Mar 12, 2021

Integration test logs

Logs
SETUP: tests/aws_backup_vault []

PRETEST: tests/aws_backup_vault

TEST: tests/aws_backup_vault
Running terraform
aws_backup_vault.named_test_resource: Creating...
aws_backup_vault.named_test_resource: Creation complete after 5s [id=example_backup_vault]

Warning: Deprecated Resource

The null_data_source was historically used to construct intermediate values to
re-use elsewhere in configuration, the same can now be achieved using locals

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Outputs:

id = "example_backup_vault"
resource_aka = "arn:aws:backup:us-east-1:013122550996:backup-vault:example_backup_vault"

Running SQL query: test-hydrate-query.sql
[
{
"name": "example_backup_vault",
"policy": ""
}
]
✔ PASSED

Running SQL query: test-list-query.sql
[
{
"arn": "arn:aws:backup:us-east-1:013122550996:backup-vault:example_backup_vault",
"name": "example_backup_vault"
}
]
✔ PASSED

Running SQL query: test-turbot-query.sql
[
{
"akas": [
"arn:aws:backup:us-east-1:013122550996:backup-vault:example_backup_vault"
],
"title": "example_backup_vault"
}
]
✔ PASSED

POSTTEST: tests/aws_backup_vault

TEARDOWN: tests/aws_backup_vault

SUMMARY:

1/1 passed.

Example query results

Results
 select
  name,
  arn,
  creation_date
from
  aws_backup_vault;
+-------------------+----------------------------------------------------------------------+---------------------+
| name              | arn                                                                  | creation_date       |
+-------------------+----------------------------------------------------------------------+---------------------+
| Default           | arn:aws:backup:us-east-1:013122550996:backup-vault:Default           | 2019-07-10 03:29:49 |
| test_backup_vault | arn:aws:backup:us-east-1:013122550996:backup-vault:test_backup_vault | 2020-03-06 09:42:02 |
+-------------------+----------------------------------------------------------------------+---------------------+

> select
  name,
  arn,
  creation_date
from
  aws_backup_vault
where
  creation_date <= (current_date - interval '90' day)
order by
  creation_date;
+-------------------+----------------------------------------------------------------------+---------------------+
| name              | arn                                                                  | creation_date       |
+-------------------+----------------------------------------------------------------------+---------------------+
| Default           | arn:aws:backup:us-east-1:013122550996:backup-vault:Default           | 2019-07-10 03:29:49 |
| test_backup_vault | arn:aws:backup:us-east-1:013122550996:backup-vault:test_backup_vault | 2020-03-06 09:42:02 |
+-------------------+----------------------------------------------------------------------+---------------------+

@bigdatasourav bigdatasourav self-assigned this Mar 12, 2021
@bigdatasourav bigdatasourav changed the title Add table for Backup Vault.closes#160 Add table aws_backup_vault.closes#160 Mar 12, 2021
@bigdatasourav bigdatasourav linked an issue Mar 15, 2021 that may be closed by this pull request
Copy link
Contributor

@Subhajit97 Subhajit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make suggested changes

Copy link
Contributor

@Subhajit97 Subhajit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts and make suggested changes

@cbruno10
Copy link
Contributor

@Subhajit97 Can you please re-review when you get a chance? Thanks!

Copy link
Contributor

@Subhajit97 Subhajit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigdatasourav Please see comments, thanks!

Copy link
Contributor

@Subhajit97 Subhajit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Subhajit97 Subhajit97 requested a review from rajlearner17 April 5, 2021 11:58
creation_date <= (current_date - interval '90' day)
order by
creation_date;
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigdatasourav can we add one more example such as

Ensure that the backups are encrypted at rest using KMS Customer Master Keys (CMKs).
Also we can do

Ensure that an Amazon Backup vault access policy is configured to prevent the deletion (accidentally or intentionally) of AWS backups in the backup vault.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc updated for policy .

Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left to add 1 or 2 more example

Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LalitLab LalitLab requested review from cbruno10 and removed request for LalitLab April 6, 2021 09:01
@cbruno10 cbruno10 merged commit 8e50d54 into main Apr 6, 2021
@cbruno10 cbruno10 deleted the issue-160 branch April 6, 2021 20:26
dbmurphy pushed a commit to dbmurphy/steampipe-plugin-aws that referenced this pull request Dec 30, 2021
This commit also updates steampipe-plugin-sdk to v0.2.7 closes turbot#294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table aws_backup_vault
4 participants