Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.10.0 #24

Merged
merged 104 commits into from
Oct 21, 2015
Merged

0.10.0 #24

merged 104 commits into from
Oct 21, 2015

Conversation

tbchrist
Copy link
Contributor

Additions:

  • Multiple sharding pool support
  • SSL replication support
  • Stream encryption support
  • Post-import index creation
  • Miscellaneous bugfixes

Tom Christ added 30 commits April 3, 2015 13:10
Add index create/drop methods on table and hook into import/export wo…
0519374 
…rkflow
Update calling info
3b75eab
Fix naming
65ad093
Add column validation and the ability to generate multiple indexes at…
331a77e 
… once
Merge branch 'master' into tchrist_import_without_index
81b8db7
Remove extraneous bang
467c686
Fix selector for add_pool command
5296fd0
First pass at adding support for multiple sharding pools
26f3224
Merge pull request #127 from Tumblr/tchrist_create_pool
d8b7bcc 
Fix selector for add_pool command
Merge branch 'master' into tchrist_import_without_index
a73a380
Add pool after syncing to collins
ded761a
Move splat operator to correct position
c8e8676
Merge pull request #129 from Tumblr/add_after_sync
9292b91 
Add pool after syncing to collins
Fix index name/metadata references
f2f06bd
Fix root cmd invocation
568f31c
Load table metadata from config when probing for shard
54ed907
Add default config value
5dfcb27
Move jetpants.yaml parsing up in the table probe hierarchy
c383207
Bound port for running service grep
da83bf9
Remove prepended whitespace
067a546
Properly escape grep regex
a796cf0
Fix var ref
d7eb59f
Merge pull request #130 from Tumblr/bound_running_grep
cbe3c01 
Bound port for running service grep
Merge branch 'master' into tchrist_import_without_index
9f70058
Merge branch 'master' into multiple_shard_pools
e3f75ca
Add table name to index transformation
c9636de
First cut at adding collins hooks
a80a20d
Fix up batch index creation
ccec788
Skip tables without indexes
d15f5e4
Use raise instead of throw
6dc5275
Tom Christ and others added 24 commits June 15, 2015 18:48
Accurately pass around shard pool
e0edf9d
Code cleanup
45529d5
Remove explicit timestamps
42cf756
Select correct pool when promoting
85ebee2
Implicitly load shard pools when loading shards
90760bd
Merge pull request #128 from Tumblr/multiple_shard_pools
bc77092 
First pass at adding support for multiple sharding pools
@bobpattersonjr
update upgrade_helper to be aware of backup slaves
4ccb992
@bobpattersonjr
update upgrade_helper to pause all child slaves together
45ae981
@bobpattersonjr
each not map
8447727
Merge pull request #133 from Tumblr/multiple_shard_pools_shard_upgrade
e95a3d2 
shard upgrade upgrade_helper updates
Only look at the sharded table config if the pool is a shard
d78e79d
Merge pull request #134 from Tumblr/shard_table_probe
68d96a8 
Only look at the sharded table config if the pool is a shard
@bobpattersonjr
upgrade helper --- clone from backup slave if available
30222b0
@bobpattersonjr
clone from backup slave if available via slave_for_clone funciton
52a2b51 
adding to upgrade helper plugin
Merge pull request #135 from Tumblr/upgrade_helper_clone_backup
37c687f 
upgrade helper --- clone from backup slave if available via slave_for_clone funciton
Add ssl replication support
b15a143
Merge pull request #137 from Tumblr/tchrist_ssl
fc24341 
Add ssl replication support
Add stream encryption for fast copy chain
caaf47f
Add config defaults
df35516
Add logic to conditionally encrypt based on target(s)
9a4bff4
Use global config setting when testing for encryption
a1462a6
Better message during master promotion
87c69d2
Merge pull request #139 from Tumblr/amar-jetpants-minor-fixes
374763d 
Better message during master promotion
Merge pull request #138 from Tumblr/tchrist_stream_encrypt
77929d7 
Tchrist stream encrypt
@komapa
Copy link
Contributor

komapa commented Sep 21, 2015

🚅 LGTM

spacejam
spacejam reviewed Sep 22, 2015
View reviewed changes
lib/jetpants/host.rb
should_encrypt = should_encrypt || should_encrypt_with?(t)
end

if Jetpants.encrypt_with && Jetpants.decrypt_with && should_encrypt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If should_encrypt is true, but an encrypt_with/decrypt_with has not been provided, is it desirable to downgrade the crypto?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, we don't silently downgrade, there is an output line below. That being said, it may be worth adding a prompt.

@spacejam
Copy link
Contributor

ship it! 💉 :rage4: 🔫

tbchrist pushed a commit that referenced this pull request Oct 21, 2015
Merge pull request #24 from tumblr/0.10.0
e5bbc19 
0.10.0
@tbchrist tbchrist merged commit e5bbc19 into master Oct 21, 2015
@tbchrist tbchrist deleted the 0.10.0 branch October 21, 2015 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbchrist @komapa @spacejam @bobpattersonjr