Update ingest command #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkinzer I tried doing what you did in cob_az_index, but this isn't quite working. It starts running, but then I get this error: Can you help figure out what else needs to happen? |
dkinzer
reviewed
Dec 14, 2022
exe/cob_web_index
Outdated
| @@ -33,12 +33,13 @@ class App | |||
| end | |||
|
|
|||
| if options["use-fixtures"] | |||
| CobWebIndex::CLI.ingest_fixtures(opts) | |||
| opts | |||
There was a problem hiding this comment.
I think your issue may be coming from this line
dkinzer
reviewed
Dec 14, 2022
exe/cob_web_index
Outdated
| else | ||
| CobWebIndex::CLI.ingest(opts.merge(ingest_path: args[0], delete_collection: true)) | ||
| opts.merge(ingest_path: args[0], delete_collection: true) |
There was a problem hiding this comment.
This should probably be opts.merge!
1 task
Fix options not passed for indexing.
dkinzer
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.