Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for resource synthesizers not added to the tuist edit project #4822

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Fix for resource synthesizers not added to the tuist edit project #4822

merged 5 commits into from
Oct 17, 2022

Conversation

devyhan
Copy link
Contributor

@devyhan devyhan commented Oct 17, 2022 •
edited by danieleformichelli
Loading

Resolves #4537

Short description 📝

Expect the ResourceSynthesizers folder to be present in the file inspector when it is defined and filled with synthesizers.

I wrote it using the existing code as much as much as possible.

How to test the changes locally 🧐

All existing tests have passed, added 4 tests below.

  • test locate when a resourceSynthesizer and git directory exists
  • test locate when a resourceSynthesizer directory exists
  • test locate when a git directory exists
  • test locate when multiple tuist directories exists

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • The title of the PR will be used as changelog entry, please make sure it is clear and suitable
  • In case the PR introduces changes that affect users, the documentation has been updated
  • Contributors have checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed

@devyhan devyhan force-pushed the ResourceSynthesizers-folder-not-added-on-edit branch from 2c4ed23 to 622143c Compare October 17, 2022 11:35
danieleformichelli
danieleformichelli approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@danieleformichelli danieleformichelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that the PR title is what goes into the Changelog, updated it accordingly

@danieleformichelli danieleformichelli changed the title fix: ResourceSynthesizers folder not added on edit Fix for resource synthesizers not added to the tuist edit project Oct 17, 2022
@danieleformichelli danieleformichelli added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Oct 17, 2022
@devyhan
chore: linting
b86f899
@devyhan
fix: Changes caused by adding the ProjectEditorMapper model
55531b6 
- Add resourceSynthesizers to graph in ProjectEditorMapperTests.swift
- By adding resourceSynthesizers, Increase graph target count in test_edit_when_there_are_helpers_and_setup_and_config_and_dependencies_and_tasks_and_plugins() 7 -> 8
@fortmarek fortmarek merged commit 6b9df6a into tuist:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieleformichelli danieleformichelli danieleformichelli approved these changes

@fortmarek fortmarek fortmarek approved these changes

Assignees
No one assigned
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResourceSynthesizers folder not added on edit
3 participants
@devyhan @danieleformichelli @fortmarek