Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XCWorkspace Equatable #524

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Fix XCWorkspace Equatable #524

merged 2 commits into from
Feb 14, 2020

Conversation

adamkhazi
Copy link
Contributor

Short description 📝

Equatable on XCWorkspace was not implemented correctly. This meant that WorkspaceOne == WorkspaceTwo would always return true.

Solution 📦

Compare both lhs and rhs XCWorkspace correctly now.

Implementation 👩‍💻👨‍💻

  • Update the Equatable implementation
  • Write tests to check equatable on XCWorkspace works now in the failure and success cases
  • Update the change log

@adamkhazi adamkhazi marked this pull request as ready for review February 14, 2020 10:42
@pepicrft pepicrft merged commit 6617f84 into tuist:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepicrft pepicrft pepicrft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamkhazi @pepicrft