Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional lastKnownFileTypes #458

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Conversation

kwridan
Copy link
Collaborator

@kwridan kwridan commented Jul 19, 2019

Part of: tuist/tuist#425

Short description 馃摑

  • Generating projects that include .c, .cpp, .mm and .hpp files using Tuist had the lastKnownFileType missing for those files
  • This causes Xcode to update the generated project to include those attributes
  • In a workflow where the generated projects are checked-in, it can result in differences appearing even though no changes were made

Solution 馃摝

  • Update the list of known file types to include those files

Part of: tuist/tuist#425

- Generating projects that include `.c`, `.cpp`, `.mm` and `.hpp` files using Tuist had the `lastKnownFileType` missing for those files
- This causes Xcode to update the generated project to include those attributes
- In a workflow where the generated projects are checked-in, it can result in differences appearing even though no changes were made
pepicrft
pepicrft previously approved these changes Jul 19, 2019
@pepicrft
Copy link
Contributor

Just a CHANGELOG entry and we can merge :)

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #458 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   81.12%   81.13%   +<.01%     
==========================================
  Files         148      148              
  Lines        7667     7671       +4     
==========================================
+ Hits         6220     6224       +4     
  Misses       1447     1447
Impacted Files Coverage 螖
Sources/xcodeproj/Project/Xcode.swift 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b4f3c42...b537f1b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #458 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   81.12%   81.13%   +<.01%     
==========================================
  Files         148      148              
  Lines        7667     7671       +4     
==========================================
+ Hits         6220     6224       +4     
  Misses       1447     1447
Impacted Files Coverage 螖
Sources/xcodeproj/Project/Xcode.swift 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b4f3c42...8593a25. Read the comment docs.

@pepicrft pepicrft merged commit 910e7b3 into master Jul 19, 2019
@pepicrft pepicrft deleted the features/additional-file-types branch July 19, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants