Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammatical issues and add some convenient getters #291

Merged
merged 22 commits into from
Sep 7, 2018

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Aug 29, 2018

Resolves #286

This PR aims to fix some grammatical issues in the name of some attributes and add some convenient methods to get the objects directly.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Fix grammatical issues
  • Add convenient getters for the reported attributes.
  • Revisit the following models and add object getters, deprecation annotations, and constructors that initialize the object passing objects instead of references:
    • Project models
    • Configuration models
    • File/Group models
    • Target models
    • Build models

@pepicrft pepicrft self-assigned this Aug 29, 2018
@ghost
Copy link

ghost commented Aug 29, 2018

Danger run resulted in 2 messages and 2 warnings; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Aug 29, 2018

Codecov Report

Merging #291 into master will decrease coverage by 0.11%.
The diff coverage is 71.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   75.72%   75.61%   -0.12%     
==========================================
  Files         116      116              
  Lines        5261     5269       +8     
==========================================
  Hits         3984     3984              
- Misses       1277     1285       +8
Impacted Files Coverage Ξ”
...odeprojTests/Objects/XCConfigurationListSpec.swift 100% <100%> (ΓΈ) ⬆️
Sources/xcodeproj/Objects/PBXLegacyTarget.swift 31.7% <100%> (ΓΈ) ⬆️
...ources/xcodeproj/Objects/XCConfigurationList.swift 95.31% <100%> (ΓΈ) ⬆️
...s/xcodeprojTests/Objects/PBXNativeTargetSpec.swift 100% <100%> (ΓΈ) ⬆️
Sources/xcodeproj/Objects/PBXNativeTarget.swift 92.1% <100%> (ΓΈ) ⬆️
Tests/xcodeprojTests/Objects/PBXProjectSpec.swift 100% <100%> (ΓΈ) ⬆️
Sources/xcodeproj/Utils/ReferenceGenerator.swift 96.96% <100%> (ΓΈ) ⬆️
...ources/xcodeproj/Sourcery/Equality.generated.swift 93.9% <100%> (ΓΈ) ⬆️
Sources/xcodeproj/Objects/PBXTarget.swift 38.37% <33.33%> (-2.88%) ⬇️
Sources/xcodeproj/Objects/PBXProject.swift 78.64% <66.66%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update f7f497b...046a44c. Read the comment docs.

@pepicrft pepicrft changed the title Fix grammatical issues and add some convenient getters [WIP] Fix grammatical issues and add some convenient getters Aug 30, 2018
@pepicrft pepicrft changed the title [WIP] Fix grammatical issues and add some convenient getters Fix grammatical issues and add some convenient getters Sep 7, 2018
@pepicrft pepicrft merged commit f3eddba into master Sep 7, 2018
@pepicrft pepicrft deleted the pluralization-issues branch September 7, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBXObjectReference property names
1 participant