Add Xcode Extension product type. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
|
Nice @briantkelley. Just one more thing! Don't forget to update the CHANGELOG with your changes. After that, it should be ready to go. Congrats on your first PR. |
As with other app extensions, the file extension is "appex" and Xcode encodes the type using the string "com.apple.product-type.xcode-extension".
|
@pepibumur, the CHANGELOG is updated (and I fixed it to follow the 1.7.0 release 🙂). Thanks! |
|
Congrats on merging your first pull request! We here at xcode.swift are proud of you! Join our slack channel to talk to other contributors. |
|
Merged @briantkelley 👏 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with other app extensions, the file extension is "appex" and Xcode encodes the type using the string "com.apple.product-type.xcode-extension".
Short description 📝
xcproj was unable to open an Xcode project with an Xcode Extension target, which is easy enough to fix.
Solution 📦
Added the reverse DNS-style identifier used by Xcode to identify this type of target to the
PBXProductTypeenum, complete with extension and unit test.This change is