Add contract test #170
Merged
Add contract test #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
force-pushed
the
contract-testing
branch
from
d3d075e
to
f4a1025
Compare
yonaskolb
reviewed
Nov 30, 2017
| range: NSRange.init(location: 0, length: content.count)) else { | ||
| return content | ||
| } | ||
| let output = (content as NSString).replacingCharacters(in: match.range, |
There was a problem hiding this comment.
Info: String.replacingOccurrences has a built in regex option.
let expression = "\\.package\\(url:\\s*\\\".+xcproj.git\\\".+\\)"
let replacement = ".package(url: \"../..\", .revision(\"\(revision)\"))"
return content.replacingOccurrences(of: expression, with: replacement, options: .regularExpression, range: nil)
There was a problem hiding this comment.
Nice! I didn't know this. I'll update it.
yonaskolb
reviewed
Nov 30, 2017
| atomically: true, | ||
| encoding: .utf8) | ||
| print("> Building XcodeGen") | ||
| try shellOut(to: "cd \(clonePath); swift build") |
There was a problem hiding this comment.
Yeah, makes sense 👍
|
Nice one! |
pepicrft
force-pushed
the
contract-testing
branch
from
f4a1025
to
c956d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #111
Short description 📝
Changes in
xcprojmight break the integration from other projects. The purpose of this PR is to add a test that tests the contract with XcodeGen. This test can be a reference to test contract with other libraries in the future.Solution 📦
Test the contract between
xcprojandxcodegencc @yonaskolbImplementation 👩💻👨💻
GIF
This change is