Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PBXBuildFile settings default to nil during decode #149

Merged

Conversation

alvarhansen
Copy link
Contributor

Resolves #137

Short description 馃摑

Currently PBXBuildFile assigns default value of empty dictionary to settings. Because of this, during encoding, this empty dictionary gets written, instead of omitting it.

Solution 馃摝

Remove default value

GIF

gif

Instead of defaulting to empty array, default to nil.
@pepicrft pepicrft added this to the 1.4.0 milestone Nov 9, 2017
@pepicrft
Copy link
Contributor

pepicrft commented Nov 9, 2017

Great job @allu22

@pepicrft pepicrft closed this Nov 9, 2017
@alvarhansen
Copy link
Contributor Author

@pepibumur Why closed but not merged?

@pepicrft pepicrft reopened this Nov 9, 2017
@pepicrft
Copy link
Contributor

pepicrft commented Nov 9, 2017

Wrong button @allu22 馃槤

@pepicrft pepicrft merged commit cf0c444 into tuist:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants