Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back BuildSettings typealias #109

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Bring back BuildSettings typealias #109

merged 1 commit into from
Oct 12, 2017

Conversation

pepicrft
Copy link
Contributor

Short description 📝

BuildSettings was a public typelias being used from other libraries. By removing it we forced those libraries to update their implementations.

Solution 📦

Bring it back since this kind of changes required a major update.

Implementation 👩‍💻👨‍💻

  • Bring the typealias back and update the objects that were using it.

GIF

gif

@pepicrft pepicrft added this to the 0.5.0 milestone Oct 12, 2017
@pepicrft pepicrft self-assigned this Oct 12, 2017
@pepicrft pepicrft requested a review from a team October 12, 2017 06:39
@yonaskolb yonaskolb merged commit a5595e0 into master Oct 12, 2017
@yonaskolb yonaskolb deleted the buildsettings branch October 12, 2017 06:52
@alvarhansen alvarhansen mentioned this pull request Nov 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonaskolb yonaskolb yonaskolb approved these changes

Assignees

@pepicrft pepicrft

Labels
type:bug
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pepicrft @yonaskolb