Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If RemoteRunnable doesn't contains BuildableReference XcodeProj removes xcscheme file #626

Closed
subdan opened this issue Jul 29, 2021 · 0 comments · Fixed by #627
Closed

Comments

@subdan
Copy link
Contributor

subdan commented Jul 29, 2021

What 🌱

If a *.xcscheme contains RemoteRunnable tag without nested BuildableReference tag XcodeProj remove this file from .xcodeproj directory.

<RemoteRunnable
         runnableDebuggingMode = "1"
         BundleIdentifier = "me.ava.Ava-Staging"
         RemotePath = "/var/containers/Bundle/Application/018F0933-05E8-4359-9955-39E0523C4246/Ava.app">
</RemoteRunnable>

Proposal 🎉

Inside XCScheme+Runnable.swift make buildableReference property optional.

public var buildableReference: BuildableReference?

Also replace the following line:

element.addChild(buildableReference.xmlElement())

with the next one:

if let buildableReference = buildableReference {
    element.addChild(buildableReference.xmlElement())
}

I will make a PR...

subdan pushed a commit to subdan/XcodeProj that referenced this issue Jul 29, 2021
pepicrft pushed a commit that referenced this issue Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant