Conversation
Port mdv to the Terminal.Gui 2.5.0 preview built from tui-cs/Terminal.Gui#5416 (ConfigurationManager removal), as part of the v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). - TEMP: vendor Terminal.Gui.2.5.0-tig-remove-cm-followup.1 nupkg/snupkg in ./local_packages with a nuget.config source, mirroring tig/winprint#272; swap to the public nuget.org package once 2.5.x ships. - Replace deleted ConfigurationManager.Enable (ConfigLocations.All) with TuiConfigurationBuilder ().ApplyToStaticFacades (). - Suppress new CS0618 on TextMateSyntaxHighlighter.GetThemeForBackground (obsolete in 2.5; still functional) with a follow-up note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
…ba423 followup.1 was built from a stale 5416 commit (93c3b3d4) with real config-load defects fixed later on the branch: CWD-relative ./.tui config was silently ignored, and a malformed config crashed before Main. Verified with followup.2 that a ./.tui/config.json in the launch CWD now applies (Theme=Light takes effect). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
Drop the vendored 5416 preview feed (local_packages/ and nuget.config) and restore Terminal.Gui 2.5.0-develop.55 from nuget.org. Same pattern as tui-cs/Editor#287. Swap to stable 2.5.x before merge. Co-authored-by: Tig <tig@users.noreply.github.com>
cursor
Bot
changed the title
Swap the nuget.org pin from 2.5.0-develop.55 to 2.5.0-beta.1. Co-authored-by: Tig <tig@users.noreply.github.com>
cursor
Bot
changed the title
66 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins public
Terminal.Gui 2.5.0-develop.55from nuget.org so mdv can be validated ahead of the v2.5.0 tag. Before merging, once stable 2.5.x is on nuget.org:mdv.csprojDo not vendor a local nupkg. The 5416 preview feed (
local_packages/,tgui-pr-5416nuget.config source) is already gone.Summary
Retargets this PR from the vendored
2.5.0-tig-remove-cm-followup.2pin to public2.5.0-develop.55as part of tui-cs/Terminal.Gui#5630 Workstream 4.API breaks already fixed (kept):
ConfigurationManager.Enable/ConfigLocations→TuiConfigurationBuilder().ApplyToStaticFacades()TextMateSyntaxHighlighter.GetThemeForBackgroundis[Obsolete]in 2.5; CS0618 suppressed with a follow-up noteNo
View.Textoverride orIAcceptTargethits.Validation
This repo has no test projects (CI is publish-on-release only). Agent reported
dotnet build0 warnings/errors and a clean-cache restore of2.5.0-develop.55from nuget.org.Refs: tui-cs/Terminal.Gui#5416, tui-cs/Terminal.Gui#5630.