Fixes #5555. Preserve explicit Scheme role reassignment#5556
Merged
YourRobotOverlord merged 1 commit intoJun 28, 2026
Merged
Conversation
Reassigning a copied explicit role to the same value must not make it implicit. Fixes tui-cs#5555
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Scheme copy/initializer edge case where reassigning an explicitly set role to the same Attribute value could incorrectly clear the explicit backing field and cause the role to be re-derived from Normal.
Changes:
- Update
Scheme.SetAttributeForRolePropertyto keep an already-explicit role explicit when reassigned the same value. - Add a regression test covering explicit
Editablepreservation after copying and changingNormal.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Terminal.Gui/Drawing/Scheme.cs | Preserves explicit role assignments when reassigned to the same value during initialization/copy scenarios. |
| Tests/UnitTestsParallelizable/Drawing/SchemeTests.cs | Adds regression coverage validating explicit Editable remains explicit after copy + reassignment. |
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserves an explicitly assigned Scheme role when a copied scheme
reassigns that role to the same Attribute.
Previously, SetAttributeForRoleProperty compared the assignment with the
resolved role value and converted a matching value to null. For copied
schemes, this erased the copied explicit value and caused the role to be
derived from Normal.
Tests
Added a regression test covering an identical Editable reassignment after
copying and changing Normal.
To pull down this PR locally: