Bump TerminalGuiVersion to 2.4.15-develop.31 (needs fixes)#263
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a50cf578ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-develop.2</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.15-develop.31</TerminalGuiVersion> |
There was a problem hiding this comment.
Resolve obsolete config APIs before bumping
This new default package version is used by every project restore, but Terminal.Gui 2.4.15-develop.31 now marks the configuration APIs we still use (SettingsScope / ConfigurationPropertyAttribute, e.g. src/Terminal.Gui.Editor/Editor.Commands.cs:24) as obsolete. Because this repo builds with TreatWarningsAsErrors, the bump workflow for this exact version reports those diagnostics as errors, so the solution is left unbuildable before tests can run. Please migrate or explicitly handle those diagnostics before raising the dependency floor.
Useful? React with 👍 / 👎.
|
Superseded by #264 (merged): develop is now migrated to Terminal.Gui's MEC config path and pinned to stable 2.4.15, which resolves the CS0618 build break these auto-bump PRs hit. Closing and deleting the branch. |
Automated bump of
TerminalGuiVersionfrom2.4.14-develop.2to2.4.15-develop.31failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.