Skip to content

Bump TerminalGuiVersion to 2.4.15-develop.31 (needs fixes)#263

Closed
tig wants to merge 1 commit into
developfrom
bump/terminal-gui-2.4.15-develop.31
Closed

Bump TerminalGuiVersion to 2.4.15-develop.31 (needs fixes)#263
tig wants to merge 1 commit into
developfrom
bump/terminal-gui-2.4.15-develop.31

Conversation

@tig

@tig tig commented Jun 28, 2026

Copy link
Copy Markdown
Member

Automated bump of TerminalGuiVersion from 2.4.14-develop.2 to 2.4.15-develop.31 failed validation (build or tests).

Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a50cf578ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Directory.Build.props
to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets).
-->
<TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-develop.2</TerminalGuiVersion>
<TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.15-develop.31</TerminalGuiVersion>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve obsolete config APIs before bumping

This new default package version is used by every project restore, but Terminal.Gui 2.4.15-develop.31 now marks the configuration APIs we still use (SettingsScope / ConfigurationPropertyAttribute, e.g. src/Terminal.Gui.Editor/Editor.Commands.cs:24) as obsolete. Because this repo builds with TreatWarningsAsErrors, the bump workflow for this exact version reports those diagnostics as errors, so the solution is left unbuildable before tests can run. Please migrate or explicitly handle those diagnostics before raising the dependency floor.

Useful? React with 👍 / 👎.

@tig

tig commented Jun 28, 2026

Copy link
Copy Markdown
Member Author

Superseded by #264 (merged): develop is now migrated to Terminal.Gui's MEC config path and pinned to stable 2.4.15, which resolves the CS0618 build break these auto-bump PRs hit. Closing and deleting the branch.

@tig tig closed this Jun 28, 2026
@tig tig deleted the bump/terminal-gui-2.4.15-develop.31 branch June 28, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant