Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak: use cached versions from pypi instead of git #106

Closed
wants to merge 1 commit into from
Closed

flatpak: use cached versions from pypi instead of git #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions org.freedesktop.tuhi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@
"buildsystem": "simple",
"sources": [
{
"type": "git",
"url": "git://anongit.freedesktop.org/xdg/pyxdg"
"type": "archive",
"url": "https://pypi.python.org/packages/47/6e/311d5f22e2b76381719b5d0c6e9dc39cd33999adae67db71d7279a6d70f4/pyxdg-0.26.tar.gz#md5=db1c2af8300ca64ce3955b3cf2490c92",
"sha512": "f5306e6e15af07df2599017500fc8ad83e722e5d5c6e4fda014aab1d77df92a3c3199a5be7a889faaecab72861e9910be9d80142d29856eb7a11f6ab9a923bd2"
whot marked this conversation as resolved.
Show resolved Hide resolved
}
],
"build-commands": [
Expand Down Expand Up @@ -106,8 +107,9 @@
"buildsystem": "simple",
"sources": [
{
"type": "git",
"url": "https://github.com/mozman/svgwrite.git"
"type": "archive",
"url": "https://pypi.python.org/packages/a6/e1/8d592fc801e1dc2958fe0c84c733ed729d4020daa1826c58978f9d601bb4/svgwrite-1.1.12.zip#md5=05780a4a8ba33c16842faf37818d670e",
"sha512": "cafce1a39c932149cd9d531c7304e8568fde9bc5abd09b548a778cc7f7f4d74327da03fb01279a3a19dd8396487c8fba974d50c6dd645be3942a4ba6d76646df"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the github package is better here than the pypi cache, removes one layer of indirection:
https://github.com/mozman/svgwrite/archive/v1.1.12.tar.gz

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have issues with dates when pulling these tags from github?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we used to but maybe not anymore? I pulled the svgwrite tarball yesterday and today and I'm getting the same md5sum for them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homebrew/homebrew-core#18044 (comment) is relevant here: basically, yes, they can change but they shouldn't, at least not that often :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC things attached to a proper release don't change (libwacom e.g. adds the md5sums to those assets too) so we should be able to use those for svgwrite at least - that link above.

}
],
"build-commands": [
Expand Down