-
Notifications
You must be signed in to change notification settings - Fork 31
Validate params files #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate params files #880
Conversation
… spec is moved out.
|
Note that the most substantive change is to break up |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## collect-components-of-namespaces #880 +/- ##
=================================================================
Coverage 83.07% 83.07%
=================================================================
Files 145 145
Lines 5713 5713
=================================================================
Hits 4746 4746
Misses 967 967 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o fit with AG/AN naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The json scheme is just for the hook, we keep the .yamls, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No complaints
908e272
into
collect-components-of-namespaces
### What problem do you want to solve? - [x] Add a GEP for the revamped interface - [x] Update earlier GEPs to reflect the changes that have become necessary after GEP 6 (since our documentation is small, it does not make sense to keep outdated things around). - [x] Add the finalised schema from #880 as an appendix to GEP 3 [Resolution on Zulip.](https://gettsim.zulipchat.com/#narrow/channel/309998-GEPs/topic/GEP.2007/near/530389224) --------- Co-authored-by: Marvin Immesberger <[email protected]>
We might want to do the last things only after renaming / replacing params in functions by custom types.