Skip to content

Conversation

@hmgaudecker
Copy link
Collaborator

@hmgaudecker hmgaudecker commented Apr 22, 2025

  • Add a json (yaml) schema based on GEP-03
  • Make sure manual validation of parameters passes
  • Once agreement is reached that this is the correct schema,
    • make a pre-commit hook out of this
    • make the document an appendix to GEP-03

We might want to do the last things only after renaming / replacing params in functions by custom types.

@hmgaudecker
Copy link
Collaborator Author

Note that the most substantive change is to break up sozialv_beitr.yaml into multiple files. Most other changes were just omissions of descriptions / names or misspelled units.

@hmgaudecker hmgaudecker changed the base branch from main to collect-components-of-namespaces April 22, 2025 22:59
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.07%. Comparing base (e1dd5df) to head (31b654e).
Report is 1 commits behind head on collect-components-of-namespaces.

Files with missing lines Patch % Lines
...sozialversicherung/kranken/beitrag/beitragssatz.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           collect-components-of-namespaces     #880   +/-   ##
=================================================================
  Coverage                             83.07%   83.07%           
=================================================================
  Files                                   145      145           
  Lines                                  5713     5713           
=================================================================
  Hits                                   4746     4746           
  Misses                                  967      967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@MImmesberger MImmesberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The json scheme is just for the hook, we keep the .yamls, right?

Copy link
Collaborator

@MImmesberger MImmesberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints

@hmgaudecker hmgaudecker merged commit 908e272 into collect-components-of-namespaces Apr 25, 2025
7 of 9 checks passed
@hmgaudecker hmgaudecker deleted the validate-params branch April 25, 2025 15:56
hmgaudecker added a commit that referenced this pull request Jul 23, 2025
### What problem do you want to solve?

- [x] Add a GEP for the revamped interface
- [x] Update earlier GEPs to reflect the changes that have become
necessary after GEP 6 (since our documentation is small, it does not
make sense to keep outdated things around).
- [x] Add the finalised schema from #880 as an appendix to GEP 3

[Resolution on Zulip.](https://gettsim.zulipchat.com/#narrow/channel/309998-GEPs/topic/GEP.2007/near/530389224)

---------

Co-authored-by: Marvin Immesberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants