Skip to content

Conversation

@hmgaudecker
Copy link
Collaborator

In limited set of experiments, it produced exactly the same result. ast.unparse is available since Python 3.9, so it's fine to use.

…n.to_source. In limited set of experiments, it produced exactly the same result.
@hmgaudecker hmgaudecker requested a review from timmens April 22, 2025 13:30
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (70f0964) to head (3a7cbe7).
Report is 62 commits behind head on collect-components-of-namespaces.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           collect-components-of-namespaces     #878      +/-   ##
====================================================================
+ Coverage                             83.05%   83.07%   +0.01%     
====================================================================
  Files                                   145      145              
  Lines                                  5714     5713       -1     
====================================================================
  Hits                                   4746     4746              
+ Misses                                  968      967       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice!

I am quite shocked that I did not find this despite extensive googling and LLM queries.

@hmgaudecker
Copy link
Collaborator Author

No reason to worry, I guess I just was lucky with my prompt, pasting the precise deprecation warning after a generic first answer...

@hmgaudecker hmgaudecker merged commit e1dd5df into collect-components-of-namespaces Apr 22, 2025
7 of 9 checks passed
@hmgaudecker hmgaudecker deleted the remove-astor branch April 22, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants