Make top-level namespace include potential derived functions #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmgaudecker
reviewed
Apr 10, 2025
Collaborator
hmgaudecker
left a comment
hmgaudecker
left a comment
There was a problem hiding this comment.
Excellent, thanks! Just fix the tests for time conversions and then it's ready to go!
hmgaudecker
force-pushed
the
fix-top-level-namespace
branch
from
86d9507 to
c20a1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
The top-level namespace did not account for derived functions that are created later. We now add place-holders when creating the top-level namespace for those derived functions.
Because tests don't work currently, I'm not 100% sure that the changes don't crash time conversions (but I'm optimistic that they didn't). Have to keep that in mind if we run into bugs when wrapping up #804.