Use qualified name for rounding keys in params files #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## collect-components-of-namespaces #824 +/- ##
===================================================================
Coverage ? 48.52%
===================================================================
Files ? 55
Lines ? 4004
Branches ? 0
===================================================================
Hits ? 1943
Misses ? 2061
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MImmesberger
merged commit b2bdda0
into
collect-components-of-namespaces
8 of 9 checks passed
hmgaudecker
added a commit
that referenced
this pull request
Jul 24, 2025
This PR collects the different components of changing GETTSIM's internal DAG from a flat namespace to a nested one. It also updates the entire interface, the core components that have nothing to do with the specifics of the German taxes and transfers system have been extracted to https://github.com/ttsim-dev/ttsim. This is a very large change spanning more than 100 individual PRs. For a near-complete list, see the changelog, here are some excerpts: - [x] Infrastructure #780 - [x] Use qualified names for rounding keys #824 - [x] Renaming #805 - [x] Fixing the check regarding overlapping periods of policy functions #830 - [x] Getting rid of TYPES_INPUT_VARIABLES and other cruft #833 - [x] Use relative paths wherever possible #957 - [x] First pass restructuring directories to separate ttsim and gettsim (#850) - [x] #908 - [x] #853 - [x] #918, #883 - [x] #920 - [x] Required interface changes (parts of #781) - [x] Convert test files from qualified name dicts to nested structure dicts #884 - [x] Make ttsim a separate package. --------- Co-authored-by: Lars Reimann <[email protected]> Co-authored-by: Marvin Immesberger <[email protected]> Co-authored-by: Tim Mensinger <[email protected]> Co-authored-by: Felix Schmitz <[email protected]> Co-authored-by: Max Jahn <[email protected]> Co-authored-by: JuergenWiemers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
Uses the qualified name instead of the leaf name to look for rounding specs in the params file. This is a temporary solution until we have tackled #823.