Remove eigenbedarf_gedeckt from Kindergeldübertrag

[MImmesberger]

Closes #758

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (3816876) to head (c8abdaf).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
+ Coverage   89.79%   89.86%   +0.06%     
==========================================
  Files          53       53              
  Lines        3802     3807       +5     
==========================================
+ Hits         3414     3421       +7     
+ Misses        388      386       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hmgaudecker]

Looks great, thanks!

However, I think the scope should be larger. We should not require eigenbedarf_gedeckt as an input variable. Maybe I am missing again the current state of things, but with #771 merged, it should be just a matter of comparing income and needs at the individual level, no?

[MImmesberger]

The only occurrence of eigenbedarf_gedeckt now is in the bg_id creation. I left it there intentionally because then we have a way to manually set the BGs until we get #763 right. If we replace it with the correct earnings check, we cannot compute scenarios where children + parents are in the same BG even when children have covered their needs for the time being (relevant for KiZ I think).

[hmgaudecker]

Fine. Then maybe add a to-do next to the input variable and in the bg_id creation, both linking #763. Just so that this is very visible!