-
Notifications
You must be signed in to change notification settings - Fork 31
fix: fall back to default value if foreign key of join_numpy is unresolved
#741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fall back to default value if foreign key of join_numpy is unresolved
#741
Conversation
join is unresolved
|
Thanks!!! |
736bf7b to
c369028
Compare
join is unresolvedjoin_numpy is unresolved
c369028 to
867d6a8
Compare
MImmesberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that was fast!
I tried it out on the branch of #739 and it works as expected. Regarding the naming: I think value_if_foreign_key_is_missing makes it clearer what is happening for the average user than value_for_unresolved_foreign_key.
|
I just renamed the new argument and adjusted the join for Unterhaltsvorschuss accordingly. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
hmgaudecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! Approval conditional on fixed tests, ofc. (feel free to merge if they'll be fixed immediately in another PR).
What problem do you want to solve?
Closes #740
join_numpynow takes a value that is used if a foreign key cannot be resolved, e.g. because it is explicitly set to-1.Todo
Closes #XXXXin the first PR comment to auto-close the relevant issue oncethe PR is accepted. This is not applicable if there is no corresponding issue.
Document PR in CHANGES.md.