Replace hh in function names by bg/fg/vg
#662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 90.95% 91.01% +0.06%
==========================================
Files 48 48
Lines 3140 3140
==========================================
+ Hits 2856 2858 +2
+ Misses 284 282 -2 ☔ View full report in Codecov by Sentry. |
hmgaudecker
approved these changes
Nov 18, 2023
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
Replace
hhin function names bybg/fg/vg, as discussed in #654 (comment).Until #601 is available, it makes no sense to also rename the
_hhparameters of the functions, sincebg_idandfg_idare not available yet.Todo
Closes #XXXXin the first PR comment to auto-close the relevant issue oncethe PR is accepted. This is not applicable if there is no corresponding issue.