Skip to content

Allow input template creation when path to root node traverses an automatically created function #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2025
Merged

Allow input template creation when path to root node traverses an automatically created function #1050

merged 4 commits into from
Jul 23, 2025

Conversation

@MImmesberger
Copy link
Collaborator

@MImmesberger MImmesberger commented Jul 23, 2025

What problem do you want to solve?

Closes #1049

@MImmesberger MImmesberger requested a review from hmgaudecker July 23, 2025 15:50
@MImmesberger MImmesberger linked an issue Jul 23, 2025 that may be closed by this pull request
BUG: Cannot create input template when providing (some) input data #1049
Closed
hmgaudecker
hmgaudecker approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for noting, analysing, and fixing so quickly!

@codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sts/ttsim/interface_dag_elements/test_templates.py 81.81% 2 Missing ⚠️
src/ttsim/interface_dag_elements/templates.py 95.45% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hmgaudecker hmgaudecker changed the title Fix #1049 Allow input template creation when path to root note goes via an automatically created function Jul 23, 2025
@hmgaudecker hmgaudecker changed the title Allow input template creation when path to root note goes via an automatically created function Allow input template creation when path to root node traverses an automatically created function Jul 23, 2025
@hmgaudecker hmgaudecker merged commit 84daa3c into collect-components-of-namespaces Jul 23, 2025
13 of 15 checks passed
@hmgaudecker hmgaudecker deleted the template-bug-1049 branch July 23, 2025 16:31
@hmgaudecker hmgaudecker mentioned this pull request Jul 23, 2025
Closed
@MImmesberger MImmesberger mentioned this pull request Jul 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmgaudecker hmgaudecker hmgaudecker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Cannot create input template when providing (some) input data

3 participants

@MImmesberger @hmgaudecker