Skip to content

Conversation

@MImmesberger
Copy link
Collaborator

What problem do you want to solve?

Closes #999

Fails if any param_function depends on a ColumnObject, with the exception being evaluation_x and policy_x (they are PolicyInputs).

@MImmesberger MImmesberger requested a review from hmgaudecker July 22, 2025 15:48
@MImmesberger MImmesberger linked an issue Jul 22, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ests/ttsim/interface_dag_elements/test_failures.py 85.71% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot!!!

Given the architecture, we cannot grant exceptions for dates, that would lead to errors when trying to use actual columns as dates. However, the two cases where we had that in GETTSIM actually should be policy_dates IMO. That is, it does not make sense to ask for the policy environment of 2020 but then evaluate it at the parameters for the introduction of the Vorsorgeaufwendungen of 2010. Put differently, in those cases we only use the piecewise polynomial to define the correct policy environment based on the date. Very different when we are talking about age/cohort-based rules.

Other than that, I just made some simplifications to the code.

@MImmesberger
Copy link
Collaborator Author

That's a bit different from what I was trying to sell before (policy_environment being a snapshot from the text of the law), but if it makes our lives easier its reasonable I'd say.

@MImmesberger MImmesberger merged commit e4e7ada into collect-components-of-namespaces Jul 23, 2025
17 checks passed
@MImmesberger MImmesberger deleted the fail-if-param-depends-on-policy branch July 23, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: Fail if param_function depends on policy_function

3 participants