Raise more errors during vectorization #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmgaudecker
changed the title
2 tasks
2 tasks
hmgaudecker
added
the
ttsim
hmgaudecker
merged commit 3437b12
into
collect-components-of-namespaces
15 checks passed
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It agentic day and I had Cursor take a stab at #869.
@timmens, could you please double-check, also what Marvin writes over there? I was a little surprised that in-place operations worked for him, maybe they only fail in corner cases? Anyhow, they are almost always bad practice and I wouldn't mind prohibiting them if there is an epsilon chance for failure.
With the additional checks, some tests fail. However, I believe they are misguided in the first place in that they contain reduction operations. So they would not make sense with scalar input, which is the case we have in mind for the vectorisation?