Skip to content

Conversation

@MImmesberger
Copy link
Collaborator

@MImmesberger MImmesberger commented Jul 21, 2025

What problem do you want to solve?

This PR gets the input names (+docstrings) of "vorjahr" inputs straight and puts them in the correct namespaces.

Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and much, much clearer, thank you! Feel free to ignore that bug for now, just skip the tests and make and issue out of it.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/_gettsim/erziehungsgeld/erziehungsgeld.py 33.33% 6 Missing ⚠️
...ozialversicherung/arbeitslosen/arbeitslosengeld.py 20.00% 4 Missing ⚠️
.../sozialversicherung/rente/grundrente/grundrente.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot!!!

@MImmesberger MImmesberger marked this pull request as ready for review July 22, 2025 09:04
@hmgaudecker hmgaudecker merged commit 4327982 into collect-components-of-namespaces Jul 22, 2025
16 of 17 checks passed
@hmgaudecker hmgaudecker deleted the vorjahr-renamings branch July 22, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants