Skip to content

Conversation

@MImmesberger
Copy link
Collaborator

@MImmesberger MImmesberger commented Jul 15, 2025

What problem do you want to solve?

Closes #1025

Todo

Add tests via main for

  • input_data_tree_is_invalid
  • environment_is_invalid
  • input_df_mapper_columns_missing_in_df
  • targets_tree_is_invalid

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Base automatically changed from split_up_fail_and_warn to collect-components-of-namespaces July 16, 2025 04:38
@MImmesberger MImmesberger requested a review from hmgaudecker July 16, 2025 18:43
Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

…_data_is_invalid' does not fail if it runs first.
@hmgaudecker
Copy link
Collaborator

Very weird that the tests passed on non-Linux platforms before my changes... Good that we do them all!

@hmgaudecker hmgaudecker force-pushed the better-failwarn-tests branch from b047678 to c005c6b Compare July 17, 2025 08:37
@MImmesberger MImmesberger merged commit 18a8fd6 into collect-components-of-namespaces Jul 17, 2025
13 of 15 checks passed
@MImmesberger MImmesberger deleted the better-failwarn-tests branch July 17, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants