-
Notifications
You must be signed in to change notification settings - Fork 31
Better fail/warn tests #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MImmesberger
merged 8 commits into
collect-components-of-namespaces
from
better-failwarn-tests
Jul 17, 2025
Merged
Better fail/warn tests #1027
MImmesberger
merged 8 commits into
collect-components-of-namespaces
from
better-failwarn-tests
Jul 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Base automatically changed from
split_up_fail_and_warn
to
collect-components-of-namespaces
July 16, 2025 04:38
hmgaudecker
approved these changes
Jul 17, 2025
Collaborator
hmgaudecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
…_data_is_invalid' does not fail if it runs first.
Collaborator
|
Very weird that the tests passed on non-Linux platforms before my changes... Good that we do them all! |
…alid' before 'input_data.flat_from_tree'.
b047678 to
c005c6b
Compare
18a8fd6
into
collect-components-of-namespaces
13 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
Closes #1025
Todo
Add tests via
mainfor