fix: add set -e to cicd pipelines

packages/cli/src/deploy/cicd/cicd.template.ts

@@ -160,9 +160,6 @@ export const getRepositoryImageBuilder = () => ({
 
               // Used in case of yarn.lock is modified.
               'RUN git checkout -- yarn.lock',
-
-              // set -e stops the execution of a script if a command or pipeline has an error.
-              'RUN set -e',
             ].join('\n'),
           },
         },

packages/cli/src/deploy/cicd/lambdas/ecsTaskReport.handler.ts

@@ -40,6 +40,10 @@ export const getEcsTaskLogsUrl = ({ ecsTaskArn }: { ecsTaskArn: string }) => {
   return ecsTaskLogsUrl.href;
 };
 
+/**
+ * - MainTagFound: means that the main has a tag, so the main pipeline should
+ * be skipped because the push was only to update versions and changelogs.
+ */
 export type Status = 'Approved' | 'Rejected' | 'MainTagFound';
 
 export type Event = {

packages/cli/src/deploy/cicd/pipelines.spec.ts

@@ -5,3 +5,25 @@ test('pipelines', () => {
     expect.arrayContaining(['pr', 'main', 'tag']),
   );
 });
+
+test('set +x', () => {
+  const branch = 'some-branch';
+
+  const tag = 'some-tag';
+
+  expect(pipelinesModule.getPrCommands({ branch })).toMatchObject(
+    expect.arrayContaining(['set -e']),
+  );
+
+  expect(pipelinesModule.getMainCommands()).toMatchObject(
+    expect.arrayContaining(['set -e']),
+  );
+
+  expect(pipelinesModule.getTagCommands({ tag })).toMatchObject(
+    expect.arrayContaining(['set -e']),
+  );
+
+  expect(pipelinesModule.getClosedPrCommands({ branch })).not.toMatchObject(
+    expect.arrayContaining(['set -e']),
+  );
+});

packages/cli/src/deploy/cicd/pipelines.ts

@@ -8,6 +8,7 @@ const executeCommandFile = (pipeline: Pipeline | 'closed-pr') =>
   `chmod +x ./cicd/commands/${pipeline} && ./cicd/commands/${pipeline}`;
 
 export const getPrCommands = ({ branch }: { branch: string }) => [
+  'set -e',
   'git status',
   'git fetch',
   /**
@@ -35,6 +36,7 @@ export const getClosedPrCommands = ({ branch }: { branch: string }) => [
 ];
 
 export const getMainCommands = () => [
+  'set -e',
   `export CARLIN_ENVIRONMENT=Staging`,
   'git status',
   'git fetch',
@@ -49,6 +51,7 @@ export const getMainCommands = () => [
 ];
 
 export const getTagCommands = ({ tag }: { tag: string }) => [
+  'set -e',
   `export CARLIN_ENVIRONMENT=Production`,
   'git status',
   'git fetch --tags',